Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge to master for v0.5.2 #119

Merged
merged 7 commits into from
Aug 9, 2023
Merged

Merge to master for v0.5.2 #119

merged 7 commits into from
Aug 9, 2023

Conversation

oblivioncth
Copy link
Owner

No description provided.

The static member variable version was flawed as it suffered from SIOF,
since TextPos' static END made use of Index's static LAST. Often, END
would be initialized before LAST resulting in END being invalid/garbage.

This approach, while slightly less terse, prevents that issue.

The only other option is to use static member functions that return a
type constructed to be that extent, which would enact RAII.

The interface would look like: Index32::last();
instead of Index32(Index32::Last).
This also fixes ambiguity warnings introduced with C++20 due to the old
operators not having proper const correctness.
Needs to be explicit so they can be used before they are defined in
other translation units.
@oblivioncth oblivioncth merged commit 7217d26 into master Aug 9, 2023
12 checks passed
@oblivioncth oblivioncth temporarily deployed to github-pages August 9, 2023 12:52 — with GitHub Actions Inactive
@oblivioncth oblivioncth temporarily deployed to github-pages August 9, 2023 12:59 — with GitHub Actions Inactive
@oblivioncth oblivioncth temporarily deployed to github-pages August 9, 2023 13:46 — with GitHub Actions Inactive
@oblivioncth oblivioncth temporarily deployed to github-pages August 9, 2023 13:53 — with GitHub Actions Inactive
@oblivioncth oblivioncth temporarily deployed to github-pages August 9, 2023 13:57 — with GitHub Actions Inactive
@oblivioncth oblivioncth temporarily deployed to github-pages August 9, 2023 13:58 — with GitHub Actions Inactive
@oblivioncth oblivioncth temporarily deployed to github-pages August 9, 2023 14:01 — with GitHub Actions Inactive
@oblivioncth oblivioncth temporarily deployed to github-pages August 9, 2023 14:02 — with GitHub Actions Inactive
@oblivioncth oblivioncth temporarily deployed to github-pages August 9, 2023 14:03 — with GitHub Actions Inactive
@oblivioncth oblivioncth temporarily deployed to github-pages August 9, 2023 14:08 — with GitHub Actions Inactive
@oblivioncth oblivioncth temporarily deployed to github-pages August 9, 2023 14:10 — with GitHub Actions Inactive
@oblivioncth oblivioncth temporarily deployed to github-pages August 9, 2023 14:14 — with GitHub Actions Inactive
@oblivioncth oblivioncth temporarily deployed to github-pages August 9, 2023 14:17 — with GitHub Actions Inactive
@oblivioncth oblivioncth temporarily deployed to github-pages August 9, 2023 14:20 — with GitHub Actions Inactive
@oblivioncth oblivioncth temporarily deployed to github-pages August 9, 2023 14:22 — with GitHub Actions Inactive
@oblivioncth oblivioncth temporarily deployed to github-pages August 9, 2023 14:28 — with GitHub Actions Inactive
@oblivioncth oblivioncth temporarily deployed to github-pages August 9, 2023 14:41 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant